On Mon, Apr 29, 2019 at 1:42 PM Pavel Hrdina <phrdina@xxxxxxxxxx> wrote: > > On Thu, Apr 25, 2019 at 03:42:36PM +0200, Fabiano Fidêncio wrote: > > When performing a tree based unattended installation, some distros > > require extra arguments to be passed to the kernel command line. > > > > Although those extra arguments are handled by > > _OsVariant::get_kernel_url_arg(), it's libosinfo responsability to > > properly inform them to the management apps. > > > > With that in mind and knowing that osinfo-db has been updated > > accordingly, we can fully rely on the command line returned by libosinfo > > and stop appending arguments returned by get_kernel_url_arg() when > > performing unattended installations. > > What happens if there is osinfo-db version installed that supports > unattended installation but the cmdline is still broken? Then the cmdline would be broken. However, as there's *no* released code with unattended installation functionality, I think that those changes may be fine, Mainly because once we do release virt-manager we'd add a Requires: osinfo-db >= specific version. [snip] _______________________________________________ virt-tools-list mailing list virt-tools-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/virt-tools-list
