On Thu, 2019-03-21 at 15:00 +0100, Pavel Hrdina wrote:
> On Wed, Mar 20, 2019 at 04:52:31PM +0100, Andrea Bolognani wrote:
> > These cover the use case "I want to get an existing guest
> > image running in the cloud, and I don't need graphics".
[...]
> > +# Simple headless guests for various architectures
> > +c = vinst.add_category("kvm-headless", "--os-variant fedora29 --import --disk %(EXISTIMG1)s --network default --rng /dev/urandom --graphics none")
>
> Do you have any specific reason to use
> '--disk %(EXISTIMG1)s --network default --rng /dev/urandom' ?
>
> We can easily use '--disk none --network none' instead to make the XML
> as minimal as possible. It will save us some changes in the future.
As mentioned in the commit message, I wanted the resulting XML files
to be representative of something you might actually encounter in the
wild: simple, but not trivial. Using '--disk none --network none'
would mean we would no longer see what virt-install defaults to for
storage controller and network interface, which is a big part of why
these tests are useful in the first place.
You have a point about '--random /dev/urandom', though: if it's
dropped, then all guests still get an RNG *except* for s390x guests,
which tells me there's some architecture-specific code that needs to
be amended there. I'm okay with both you dropping that option before
pushing or leaving it there: either way, I'll post follow-up patches.
--
Andrea Bolognani / Red Hat / Virtualization
_______________________________________________
virt-tools-list mailing list
virt-tools-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/virt-tools-list
