Re: [PATCH] virt-install: Do not warn about consoles on s390x

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 3/14/19 9:50 AM, Christian Borntraeger wrote:
s390x guests usually detect the sclp or virtio console. The current
warning might actually break setups. Let us disable the warning.

Reported-by: Andre Wild <wild1@xxxxxxxxxxxxx>
Signed-off-by: Christian Borntraeger <borntraeger@xxxxxxxxxx>
---
  virt-install | 6 +++---
  1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/virt-install b/virt-install
index d7af107b..291b4a0a 100755
--- a/virt-install
+++ b/virt-install
@@ -402,9 +402,9 @@ def _show_nographics_warnings(options, guest, installer):
          console_type = serial_arm_arg
      if guest.devices.console[0].target_type in ["virtio", "xen"]:
          console_type = hvc_arg
-    if guest.os.is_ppc64() or guest.os.is_arm_machvirt():
-        # Later arm/ppc kernels figure out console= automatically, so don't
-        # warn about it.
+    if guest.os.is_ppc64() or guest.os.is_arm_machvirt() or guest.os.is_s390x:
s/guest.os.is_s390x/guest.os.is_s390x()/

+        # Later arm/ppc/s390x kernels figure out console= automatically, so
+        # don't warn about it.
          return
for args in (options.extra_args or []):


With the change
Reviewed-by: Boris Fiuczynski <fiuczy@xxxxxxxxxxxxx>


--
Mit freundlichen Grüßen/Kind regards
   Boris Fiuczynski

IBM Deutschland Research & Development GmbH
Vorsitzender des Aufsichtsrats: Matthias Hartmann
Geschäftsführung: Dirk Wittkopp
Sitz der Gesellschaft: Böblingen
Registergericht: Amtsgericht Stuttgart, HRB 243294

_______________________________________________
virt-tools-list mailing list
virt-tools-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/virt-tools-list




[Index of Archives]     [Linux Virtualization]     [KVM Development]     [CentOS Virtualization]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite Forum]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]     [Video 4 Linux]

  Powered by Linux