On 3/7/19 7:52 AM, Fabiano Fidêncio wrote: > This series provides the 3rd part of unattended installation support and > consists in: > > - "installertreemdia: Set user specified --location as the installer > URL": > - Fix unattended installations when the user explicitly pass > --location. This requires unreleased (but about to be merged) > libosinfo patches; > > - all the other patches: > - dealing with --cdrom explicitly set by the user, meaning that an > express installation would be performed from the media. > > Fabiano Fidêncio (9): > installertreemdia: Set user specified --location as the installer URL > installertremeedia: Add an internal Libosinfo.Media attribute > installertreemedia: Get medias' kernel/initrd paths from Libosinfo > installertreemedia: Pass media down to prepare_install_script() > unattended: Properly set the installation source > osdict: Refactor get_install_script() > unattended: Pass the media down to get_install_script() > osdict: Deal with medias' installer scripts > virt-install: Deal with "--cdrom" unattended installations > > virt-install | 3 ++ > virtinst/installertreemedia.py | 15 ++++++- > virtinst/osdict.py | 77 ++++++++++++++++++++++------------ > virtinst/unattended.py | 30 ++++++++++--- > 4 files changed, 93 insertions(+), 32 deletions(-) > I tweaked patch #1 a bit to bump the libosinfo unattended dep to require set_installation_url, and silence pylint on older libosinfo. patch 2-4 weren't necessary after some tweaks in urldetect.py. we are already doing much of the same stuff those patches added, I just needed to reorganize it a bit to make sure it was more easily accessible. see the 3 patches in git before your series. The rest of this series is pushed now. Nice work! There's definitely some funkyness in virt-install with option handling, I don't like converting options.cdrom into options.location magically like that, but I'll take a look at the whole picture when the windows support bits are added which I imagine will change things Thanks, Cole _______________________________________________ virt-tools-list mailing list virt-tools-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/virt-tools-list
