On Tue, Mar 05, 2019 at 11:24:49AM +0100, Christophe Fergeau wrote: > A few comments on the first patch, for the rest of the series, > > Reviewed-by: Christophe Fergeau <cfergeau@xxxxxxxxxx> > > Did you get feedback from people involved with translations regarding > these changes? No, but in general case it will have no impact on them. We did this in libvirt a while back & have seen no complaints either. We outsourced translation to Zanata, and the people doing translations in Zanata see zero changes in content presented to them, as zanata unpacks .po files into its own DB & reconciles with the .pot. So all the metadata we discard from the .po files was never used by Zanata in the first place, as it gets it all from the pot. In the unlikely event anyone was using the .po files in git, the metadata they were relying on was always outdated & thus misleading and/or useless. They would have to re-generate the .po file to get accurate source locations. With the new system we discarded all the inaccurate metadata, and people can fully up2date metadata by running 'make update-po'. IOW, this is better for any one using .po files directly, as the info they see is now actually accurate. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :| _______________________________________________ virt-tools-list mailing list virt-tools-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/virt-tools-list
