Re: [virt-manager PATCH] virtinst: cli: fix ParserBoot to return the parsed object

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Mar 01, 2019 at 04:50 PM +0100, Pavel Hrdina <phrdina@xxxxxxxxxx> wrote:
> This fixes virt-xml to return an XML for command:
>
>     virt-xml --build-xml --boot os_type=hvm
>
> The VirtCLIParser.parse() expects the _parse() method to return
> the parsed object.
>
> Signed-off-by: Pavel Hrdina <phrdina@xxxxxxxxxx>
> ---
>
> Pushed
>
>  virtinst/cli.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/virtinst/cli.py b/virtinst/cli.py
> index d56fade8..7a406eb4 100644
> --- a/virtinst/cli.py
> +++ b/virtinst/cli.py
> @@ -1912,7 +1912,7 @@ class ParserBoot(VirtCLIParser):
>          if boot_order:
>              inst.bootorder = boot_order
>  
> -        super()._parse(inst)
> +        return super()._parse(inst)
>  
>      @classmethod
>      def __init_class__(cls, **kwargs):
> -- 
> 2.20.1
>
> _______________________________________________
> virt-tools-list mailing list
> virt-tools-list@xxxxxxxxxx
> https://www.redhat.com/mailman/listinfo/virt-tools-list
>

Reviewed-by: Marc Hartmayer <mhartmay@xxxxxxxxxxxxx>

-- 
Kind regards / Beste Grüße
   Marc Hartmayer

IBM Deutschland Research & Development GmbH
Vorsitzende des Aufsichtsrats: Matthias Hartmann
Geschäftsführung: Dirk Wittkopp
Sitz der Gesellschaft: Böblingen
Registergericht: Amtsgericht Stuttgart, HRB 243294


_______________________________________________
virt-tools-list mailing list
virt-tools-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/virt-tools-list




[Index of Archives]     [Linux Virtualization]     [KVM Development]     [CentOS Virtualization]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite Forum]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]     [Video 4 Linux]

  Powered by Linux