Re: [virt-manager PATCH] graphics: move all listen code into one place

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2/22/19 10:44 AM, Pavel Hrdina wrote:
> Instead of duplicating the code into CLI and GUI move it into graphics
> device file which is used from both places.  This also fixes a bug in
> virt-xml where changing listen to address was not working.
> 
> This also changes behavior to always configure one listen type when
> using CLI listen option or GUI.  If user wants to modify only specific
> listen type they can use listens[] options from CLI.
> 
> Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1565968
> 
> Signed-off-by: Pavel Hrdina <phrdina@xxxxxxxxxx>
> ---
>  tests/xmlparse-xml/change-graphics-out.xml |  1 -
>  virtManager/addhardware.py                 |  2 +-
>  virtManager/domain.py                      | 13 +++++-------
>  virtinst/cli.py                            | 12 +----------
>  virtinst/devices/graphics.py               | 24 +++++++++++-----------
>  5 files changed, 19 insertions(+), 33 deletions(-)
> 

Reviewed-by: Cole Robinson <crobinso@xxxxxxxxxx>

- Cole

_______________________________________________
virt-tools-list mailing list
virt-tools-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/virt-tools-list



[Index of Archives]     [Linux Virtualization]     [KVM Development]     [CentOS Virtualization]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite Forum]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]     [Video 4 Linux]

  Powered by Linux