On 1/21/19 10:30 AM, Lin Ma wrote:
> Signed-off-by: Lin Ma <lma@xxxxxxxx>
> ---
> virtManager/vsockdetails.py | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/virtManager/vsockdetails.py b/virtManager/vsockdetails.py
> index 7e4e8134..a4920012 100644
> --- a/virtManager/vsockdetails.py
> +++ b/virtManager/vsockdetails.py
> @@ -56,6 +56,11 @@ class vmmVsockDetails(vmmGObjectUI):
> else:
> cid = self.MIN_GUEST_CID
>
> + label = self.widget("vsock-auto").get_label().split(" (")[0]
> + if is_auto and self.vm.is_active():
> + label += " (%s %s)" % (_("CID ="), cid)
> + self.widget("vsock-auto").set_label(label)
> +
> self.widget("vsock-auto").set_active(is_auto)
> self.widget("vsock-cid").set_value(cid)
> self.widget("vsock-cid").set_visible(not is_auto)
Looks good to me.
I find this:
Guest CID: [ ] Auto [12 +-]
Auto CID = 3
less confusing than:
Guest CID: [ ] Auto (CID = 3) [12 +-]
but I can see that's a convention virt-manager already uses (e.g. for
gfxdetails Port).
Reviewed-by: Slavomir Kaslev <kaslevs@xxxxxxxxxx>
Cheers,
-Slavi
_______________________________________________
virt-tools-list mailing list
virt-tools-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/virt-tools-list
