On Tue, Jan 08, 2019 at 12:17 AM +0100, Cole Robinson <crobinso@xxxxxxxxxx> wrote: > On 01/07/2019 03:44 PM, Cole Robinson wrote: >> On 12/18/2018 08:44 AM, Marc Hartmayer wrote: >>> Marc Hartmayer (14): >>> xmlapi: refactor node_is_text function >>> test_urls: simplify the sorting >>> cli: register a parser class only once >>> cli: add register classmethod to each parser >>> cli: rename ParseMemdev to ParserMemdev >>> cli: use Python3 conventions: super() >>> cli: don't use monkey patching >>> cli: refactor noset_cb >>> netlist: use NamedTuple for storing a network device >>> domain: os: use decorator syntax for declaring properties >>> domain: convert _change_boot_order to a instance method >>> domain: remove indirection >>> domain: use else/elif since the conditions are mutually exclusive >>> domain: add docstring for _convert_old_boot_order >>> > > Looks like some of the cli bits upset ci. Maybe some newer python3 dep > slipped in there: > > https://ci.centos.org/job/virt-manager-check/systems=libvirt-debian-9/309/console > > I don't have time to check now but I will look at it tomorrow Hmmm… It seems that with Python < 3.6 it’s not possible for a metaclass to call a method in the defined class before it’s done with its __new__. See https://stackoverflow.com/a/28605694 for more information about that topic. As a workaround we can use hard coded values here instead of super().__init_subclass__(**kwargs). e.g. VirtCLIParser.__init_class__(**kwargs) instead of super().__init_class__(**kwargs) for the ParserHostdev. I can post a v2 of this patch if you want to. > > Thanks, > Cole > -- Kind regards / Beste Grüße Marc Hartmayer IBM Deutschland Research & Development GmbH Vorsitzende des Aufsichtsrats: Matthias Hartmann Geschäftsführung: Dirk Wittkopp Sitz der Gesellschaft: Böblingen Registergericht: Amtsgericht Stuttgart, HRB 243294 _______________________________________________ virt-tools-list mailing list virt-tools-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/virt-tools-list
