On Mon, Dec 10, 2018 at 10:36:13AM +0100, Fabiano Fidêncio wrote:
> Whenever virt-install is called without pssing --disk or --memory, let's
> fallback to libosinfo's recommended resources instead (when those are
> available) instead of erroring out.
I'll push it in a while with the fix squashed in. Just one small note,
the test adjustments should be part of the commits that change the
code, if possible, every commit should pass all checks.
> NOTE: There's no tests written for these changes. So, Cole/Pavel,
> please, I'll need a little bit of your time to discuss how to adapt the
> current tests in order to test those features considering that a bunch
> of tests are not passing the "--memory" and virt-manager's test suite
> just defaults to 64 MB.
Right, in our tests/clitest.py:295 we have these lines:
if "--ram " not in cli:
args += " --ram 64"
If we remove them, it would break a lot of test cases and we would have
to add the --memory line to every single group of test case, that would
be one solution, another that I was able to think of is that we can add
a special "--memory osinfo" option to explicitly test this new feature.
We would have to remove that option from command line in the test suite.
Pavel
Attachment:
signature.asc
Description: PGP signature
_______________________________________________ virt-tools-list mailing list virt-tools-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/virt-tools-list
