On 12/14/2018 09:34 AM, Slavomir Kaslev wrote:
This patchset adds support for vsock sockets to Virtual Machine Manager.
Changes in v3:
- make UI preserve last used CID when switching Auto CID assignment on/off
Changes in v2:
- added clitest
- addressed code review feedback
- split vsock details UI and share it between Hardware Details and Add
Hardware UI
Slavomir Kaslev (4):
virtinst: Add vsock device type
virt-manager: Add vsock sockets details UI
virt-manager: Add support for vsock device to Hardware Details UI
virt-manager: Add support for vsock devices to Add Hardware UI
Sorry for the late review on this series. It looks pretty good to me!
Nice work. I've pushed with some small changes:
- Removed the CID validation from virtinst/devices/vsock.py, libvirt
will handle that for us. Adjusted vsockdetails.py to match
- Changed the UI lables from "VM Sockets" to "Virtio VSOCK". A bit
too technical sounding but then again that's the name that's most
familiar to people IMO
Thanks,
Cole
_______________________________________________
virt-tools-list mailing list
virt-tools-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/virt-tools-list
