The screen estate used by the virt-manager itself in the console mode reduces the amount of screen estate available to the VM. virt-manager currently supports the fullscreen option to make maximum use of the available screen. Unfortunately, this hides the OS taskbar, which makes this approach less usable for workflows that need to use the taskbar, e.g. when switching between many different VMs at the same time. The PR introduces a "hide decorations" menu option. This option hides the menubar and the OS window decorations of the VM viewer. Essentially, it's the fullscreen option without actually going full screen, i.e. the window mechanics are still preserved and the window can still be hidden, obscured and so on. This mode can be turned off much like the fullscreen option - my moving mouse near the top edge which shows the usual two-button box. The PR also slightly changes how the "revealer" box works. In non-fullscreen mode the assumption that it's easy to navigate to the exact top pixel of the window no longer holds. So the eventbox is now a completely separate rectangle from the revealer itself and thus can span much wider span of the window and be more than a single pixel high. This way we don't grab mouse events from much larger area than we want whenever the box with buttons is shown which would have been an issue with the previous implementation if I just increased the width of the eventbox. Thanks! Povilas Kanapickas (4): console: Extract fullscreen exit overlay code to separate class console: Extract menu toolbar hiding code to separate function console: Add a way to hide toolbars and window decorations console: Make the "show decorations" menu easier to trigger ui/details.ui | 9 ++ virtManager/console.py | 277 ++++++++++++++++++++++++++--------------- virtManager/details.py | 5 + 3 files changed, 193 insertions(+), 98 deletions(-) -- 2.17.1 _______________________________________________ virt-tools-list mailing list virt-tools-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/virt-tools-list
