On Fri, 2018-10-12 at 14:51 -0500, Jonathon Jongsma wrote: > In fullscreen mode, we attempt to enable a guest display for each client > monitor and then place a fullscreen window for each display on the > appropriate monitor. Previously, we were using gtk_window_move() to move > the window to the proper monitor, and then calling > gtk_window_fullscreen() to enter fullscreen mode on that monitor. > However, under wayland, gtk_window_move() no longer has any effect for > toplevel windows, so all displays were showing up on top of eachother on > the same client monitor. > > Fortunately, Gtk+ 3.18 added a new gtk_window_fullscreen_on_monitor() > API that works on Wayland. In theory this allows us to remove the call > to gtk_window_move() from the code. But to avoid potentially changing > behavior on xorg or older systems, I left the existing logic. > > This requires a dependency bump for gtk+ from 3.12 to 3.18. Gtk 3.18 is > provided by the following distributions (or newer): > - RHEL 7.4 > - Fedora 23 > - Ubuntu 16.04LTS Note that this broke building on Debian 8: compare [1] with [2]. If this is considered acceptable then perhaps it's a good idea to document it so that users will be aware; and by all means let me know so I can drop the corresponding job from the CI environment. [1] https://ci.centos.org/view/libvirt/job/virt-viewer-build/76/ [2] https://ci.centos.org/view/libvirt/job/virt-viewer-build/77/ -- Andrea Bolognani / Red Hat / Virtualization _______________________________________________ virt-tools-list mailing list virt-tools-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/virt-tools-list
