On 10/2/18 11:03 PM, Cole Robinson wrote:
On 09/26/2018 08:36 AM, Michal Privoznik wrote:
On 09/25/2018 11:12 AM, Lin Ma wrote:
Lin Ma (3):
cli: disk: add pr.managed=, pr.type=, pr.path= and pr.mode= support
details: Add disk pr.managed and pr.path options to support SCSI PR
addhardware: Add disk pr.managed and pr.path options to support SCSI
PR
man/virt-install.pod | 13 +++++
.../compare/virt-install-many-devices.xml | 9 +++
tests/clitest.py | 1 +
ui/addhardware.ui | 56 ++++++++++++++++++
ui/details.ui | 57
+++++++++++++++++++
virtManager/addhardware.py | 42 ++++++++++++++
virtManager/details.py | 47 ++++++++++++++-
virtManager/domain.py | 15 ++++-
virtinst/cli.py | 5 ++
virtinst/devices/disk.py | 9 +++
10 files changed, 252 insertions(+), 2 deletions(-)
Not a virt-manager developer, but since I wrote libvirt part of the
feature here are my thoughts. Do whatever you want with it O:-)
I think virt-manager should support only managed mode, if anything. The
unmanaged mode is mostly for testing and requires some setting up on
administrator side. It is not secure either - domain running under any
seclabel must be able to connect to pr-helper socket.
Managed mode spawns one pr-helper per domain, kills it automatically on
domain shutdown and labels the socket correctly.
Yes I agree. This should be just a checkbox for 'Peristent
Reservations' and hidden for non-scsi.
That said see the other mail I sent:
https://www.redhat.com/archives/virt-tools-list/2018-October/msg00021.html
If a raw XML editing mode works out, this is likely one of the UI
options I would drop, it's a power user option only applicable to a
particular advanced usecase. That said in the meantime I will accept a
patch
Thanks,
Cole
will do, Thank Michal and Colefor the suggestions.
Lin
_______________________________________________
virt-tools-list mailing list
virt-tools-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/virt-tools-list
