[PATCH 06/10] details: Pin network-model label directly to combo to simplify tests

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



This approach is used in majority of other places and allows the
combobox items to be selected directly instead of typing text in tests.

Signed-off-by: Povilas Kanapickas <povilas@xxxxxxxx>
---
 tests/uitests/details.py | 5 +++--
 ui/details.ui            | 4 ++--
 2 files changed, 5 insertions(+), 4 deletions(-)

diff --git a/tests/uitests/details.py b/tests/uitests/details.py
index 1dd83046..d19afb36 100644
--- a/tests/uitests/details.py
+++ b/tests/uitests/details.py
@@ -201,10 +201,11 @@ class Details(uiutils.UITestCase):
 
         # Network values
         tab = self._select_hw(win, "NIC :54:32:10", "network-tab")
-        src = tab.find(None, "combo box", "Network source:")
-        tab.find("Device model:", "text").text = "rtl8139"
+        src = tab.find("Network source:", "combo box")
         src.click()
         tab.find_fuzzy("macvtap", "menu item").click()
+        tab.find("Device model:", "combo box").click_combo_entry()
+        tab.find("rtl8139", "menu item").click()
         mode = tab.find_fuzzy("Source mode:", "combo box")
         mode.click_combo_entry()
         self.assertTrue(mode.find("Bridge", "menu item").selected)
diff --git a/ui/details.ui b/ui/details.ui
index 5a35a156..f7e8f1f7 100644
--- a/ui/details.ui
+++ b/ui/details.ui
@@ -3909,7 +3909,7 @@
                                             <property name="halign">end</property>
                                             <property name="label" translatable="yes">Device mode_l:</property>
                                             <property name="use_underline">True</property>
-                                            <property name="mnemonic_widget">network-model-combobox</property>
+                                            <property name="mnemonic_widget">network-model</property>
                                           </object>
                                           <packing>
                                             <property name="left_attach">0</property>
@@ -3938,7 +3938,7 @@
                                             <property name="has_entry">True</property>
                                             <signal name="changed" handler="on_network_model_combo_changed" swapped="no"/>
                                             <child internal-child="entry">
-                                              <object class="GtkEntry" id="network-model-combobox">
+                                              <object class="GtkEntry" id="network-model-entry">
                                                 <property name="can_focus">True</property>
                                               </object>
                                             </child>
-- 
2.17.1


_______________________________________________
virt-tools-list mailing list
virt-tools-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/virt-tools-list



[Index of Archives]     [Linux Virtualization]     [KVM Development]     [CentOS Virtualization]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite Forum]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]     [Video 4 Linux]

  Powered by Linux