Hi On Fri, Aug 31, 2018 at 8:32 AM, Victor Toso <victortoso@xxxxxxxxxx> wrote: > Hi, > > On Tue, Jul 31, 2018 at 03:41:09PM +0200, marcandre.lureau@xxxxxxxxxx wrote: >> From: Marc-André Lureau <marcandre.lureau@xxxxxxxxxx> >> >> A mere app::enable-accel notification shouldn't modify the >> sensitivity, which is handled for all menu items elsewhere, leave the >> current state untouched. >> >> Signed-off-by: Marc-André Lureau <marcandre.lureau@xxxxxxxxxx> > > Not sure if this could introduce regression around > https://bugzilla.redhat.com/show_bug.cgi?id=1152574 > > Before, the code was always setting sensitive to FALSE on > app:enable-accel. With Jonathon's commit 65560fa4664e, it was > changed to take in consideration if display existed. > > Not sure how to test. > I lack arguments on why this patch was needed, let's drop it for now. I'll add it back when I remember or can better explain the reason. thanks >> --- >> src/virt-viewer-window.c | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/src/virt-viewer-window.c b/src/virt-viewer-window.c >> index 301a3bf..b9b8ce9 100644 >> --- a/src/virt-viewer-window.c >> +++ b/src/virt-viewer-window.c >> @@ -219,7 +219,6 @@ rebuild_combo_menu(GObject *gobject G_GNUC_UNUSED, >> menu = GTK_WIDGET(gtk_builder_get_object(self->priv->builder, "menu-send")); >> gtk_menu_item_set_submenu(GTK_MENU_ITEM(menu), >> GTK_WIDGET(virt_viewer_window_get_keycombo_menu(self))); >> - gtk_widget_set_sensitive(menu, (self->priv->display != NULL)); >> } >> >> static void >> -- >> 2.18.0.321.gffc6fa0e39 _______________________________________________ virt-tools-list mailing list virt-tools-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/virt-tools-list
