----- Original Message -----
> From: "Marc-André Lureau" <marcandre.lureau@xxxxxxxxxx>
> To: "Xiaodai Wang" <xiaodwan@xxxxxxxxxx>
> Cc: "virt-tools-list" <virt-tools-list@xxxxxxxxxx>
> Sent: Wednesday, August 1, 2018 9:46:47 PM
> Subject: Re: [PATCH 00/22] Add QEMU-like UI: VT console &basic VM state
>
> Hi
>
> On Wed, Aug 1, 2018 at 1:50 PM, Xiaodai Wang <xiaodwan@xxxxxxxxxx> wrote:
> > Sorry, i didn't receive the email of "patch 10/22", but i can find it in
> > virt-tools-list.
> > I just Added my comments here.
> >
> > 1)
> > + vte = gtk_label_new(_("Console support is compiled out!"));
> >
> > I think the hints could be changed to be more general for all users. It may
> > be hard to understand
> > for users who don't know programming.
>
> What do you recommend instead?
>
If vte is compiled out, it's better to hide or grey out the menu item and give a warning or debug
message to show why it's not supported.
I did not receive this mail ' [PATCH 20/22] app: add "machine" UI', either.
Here is my other comments.
1. Since virt-viewer have -w and -r options which can wait for a vm to startup, It's better to add a 'Run' menu to start the VM.
2. The 'Pause' menu item should be changed to 'Resume' after pausing the VM, and changed to 'pause' again after running.
3. + <property name="label" translatable="yes">_Machine</property>
I prefer 'Virtual Machine' to 'Machine'. It's same as virt-manager.
4. <property name="label" translatable="yes">_Reset</property>
Does 'Reset' means 'Reboot'?
<property name="label" translatable="yes">_Power down</property>
Does 'Power down' means 'Shut Down'?
I think the menu item name should be same as other products of redhat, like virt-manager, ovirt.
Thanks
xiaodwan
_______________________________________________
virt-tools-list mailing list
virt-tools-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/virt-tools-list
