On 07/18/2018 06:00 AM, Lin Ma wrote:
Reflect controllers <-> disks mapping relationship for not only scsi, But other storage controllers. As a bonus, These controllers are not allowed to be removed if there are disks attached to them. Signed-off-by: Lin Ma <lma@xxxxxxxx> --- virtManager/details.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/virtManager/details.py b/virtManager/details.py index 145101c2..4b145602 100644 --- a/virtManager/details.py +++ b/virtManager/details.py @@ -3025,7 +3025,7 @@ class vmmDetails(vmmGObjectUI): can_remove = False if controller.type == "pci": can_remove = False - if controller.type == "scsi": + elif controller.type in ["scsi", "sata", "ide", "fdc"]: model = self.widget("controller-device-list").get_model() model.clear() for disk in _calculate_disk_bus_index(self.vm.xmlobj.devices.disk):
Sorry for the review delay. I've pushed this patch now Thanks, Cole _______________________________________________ virt-tools-list mailing list virt-tools-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/virt-tools-list