Re: [PATCH] tpm: allow hotplug operation so error is reported by libvirt

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jun 12, 2018 at 2:52 PM, Stefan Berger
<stefanb@xxxxxxxxxxxxxxxxxx> wrote:
> Perform a hotplug operation so that we get the error notification
> about unsupported TPM hotplug operation and we can alert the user
> that the change will only take effect upon domain shutdown.
>
> Signed-off-by: Stefan Berger <stefanb@xxxxxxxxxxxxxxxxxx>

Reviewed-by: Marc-André Lureau <marcandre.lureau@xxxxxxxxxx>

> ---
>  virtManager/domain.py | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/virtManager/domain.py b/virtManager/domain.py
> index 3eb860ec..8688f282 100644
> --- a/virtManager/domain.py
> +++ b/virtManager/domain.py
> @@ -991,7 +991,10 @@ class vmmDomain(vmmLibvirtObject):
>          if model != _SENTINEL:
>              editdev.model = model
>
> -        self._redefine_xmlobj(xmlobj)
> +        if do_hotplug:
> +            self.hotplug(device=editdev)
> +        else:
> +            self._redefine_xmlobj(xmlobj)
>
>
>      ####################
> --
> 2.14.4
>

_______________________________________________
virt-tools-list mailing list
virt-tools-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/virt-tools-list




[Index of Archives]     [Linux Virtualization]     [KVM Development]     [CentOS Virtualization]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite Forum]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]     [Video 4 Linux]

  Powered by Linux