On Mon, Apr 30, 2018 at 03:16:36PM +0100, Daniel P. Berrangé wrote: > On Mon, Apr 30, 2018 at 04:09:24PM +0200, Pavel Hrdina wrote: > > On Mon, Apr 30, 2018 at 11:44:23AM +0100, Daniel P. Berrangé wrote: > > > The current OS distro selection UI is fairly cumbersome to use. First > > > you need to decide on a variant, then decide a distro and then look for > > > the version you want. The list is filtered by default so only a subset > > > of OS are displayed. So for less common distros you'll then need to > > > start again and tell it to show all OS to try to find the one you want. > > > > > > The core problem is that we have an incredibly large list and want to > > > make it easy for the user to find a specific entry. The modern UI > > > paradigm for this problem is to provide interactive search with > > > live updated results. The current UI does provide an interactive search > > > facility on the OS version results, but you still have to first select a > > > variant to be able to use the search which is unhelpful. > > > > > > This patch attempts to better apply the search UI design to the OS selection > > > problem. We get rid of the notion of variants, distros and version, and > > > provide a single text entry box in which the user can type a few letters > > > of the OS name. As they type, a popover displays the matching results > > > filtered on OS name. By default end of life OS will be hidden, so in > > > general there will only be a small handful of results left after just > > > typing a few characters. This makes it very quick to find and select the > > > desired OS, without needing to provide a mutli-step navigation hierarchy. > > > > > > https://bugzilla.redhat.com/show_bug.cgi?id=1464306 > > > > > > Signed-off-by: Daniel P. Berrangé <berrange@xxxxxxxxxx> > > > --- > > > tests/osdict.py | 26 ---- > > > ui/create.ui | 205 +++++++----------------- > > > ui/oslist.ui | 104 +++++++++++++ > > > virtManager/create.py | 423 +++++++++----------------------------------------- > > > virtManager/oslist.py | 106 +++++++++++++ > > > virtinst/osdict.py | 88 +++-------- > > > 6 files changed, 359 insertions(+), 593 deletions(-) > > > create mode 100644 ui/oslist.ui > > > create mode 100644 virtManager/oslist.py > > > > [...] > > > > > diff --git a/ui/oslist.ui b/ui/oslist.ui > > > new file mode 100644 > > > index 00000000..2424e900 > > > --- /dev/null > > > +++ b/ui/oslist.ui > > > @@ -0,0 +1,104 @@ > > > +<?xml version="1.0" encoding="UTF-8"?> > > > +<!-- Generated with glade 3.20.4 --> > > > +<interface> > > > + <requires lib="gtk+" version="3.14"/> > > > + <object class="GtkPopover" id="vmm-oslist"> > > > + <property name="width_request">400</property> > > > + <property name="height_request">300</property> > > > > s/300/280/ > > > > The popover is to large to fit into the non-resizable vm-create window. > > Why is that a problem? It doesn't matter if it extends over the sides > of the vm-create window. Urgh, I see, this is a X11 vs Wayland difference. Rather than making the popup smaller, I'm making the create window bigger. This will stop it changing size depending on which install method is asked for - it will always get size large enough for all methods. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :| _______________________________________________ virt-tools-list mailing list virt-tools-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/virt-tools-list
