From: Marc-André Lureau <marcandre.lureau@xxxxxxxxxx> Hi, The <vmcoreinfo> feature allows a guest to provide debug details when producing dump. It's useful in particular for Linux guests with KASLR enabled, as otherwise the dump are difficult to analyze. This patch set adds virt-install support for vmcoreinfo domain feature. Whenever the host libvirt/qemu is recent enough, and the VM is x86 or arm-virt, we can assume <vmcoreinfo/> is supported and enable it by default (unless --feature vmcoreinfo=on/off is given, or changed via API) Marc-André Lureau (6): tests/virtconv: ignore skip exceptions connection: support checking for a list of features virtinst: add <vmcoreinfo/> feature virtinst/support: add SUPPORT_CONN_VMCOREINFO check tests: add xmlparse/change vmcoreinfo test virtinst: add <vmcoreinfo/> by default on x86 & arm-virt .../compare/virt-convert-ovf-compare.xml | 1 + .../compare/virt-convert-vmx-compare.xml | 1 + .../compare/virt-install-aarch64-cdrom.xml | 6 ++++ .../compare/virt-install-aarch64-graphics.xml | 3 ++ .../compare/virt-install-aarch64-kvm-gic.xml | 1 + .../compare/virt-install-aarch64-kvm-import.xml | 3 ++ .../compare/virt-install-aarch64-machdefault.xml | 3 ++ .../compare/virt-install-aarch64-machvirt.xml | 3 ++ .../compare/virt-install-arm-defaultmach-f20.xml | 3 ++ .../compare/virt-install-arm-kvm-import.xml | 3 ++ .../compare/virt-install-arm-virt-f20.xml | 3 ++ .../compare/virt-install-boot-uefi.xml | 1 + .../compare/virt-install-f21-kvm-remote.xml | 1 + .../compare/virt-install-features-vmcoreinfo.xml | 28 +++++++++++++++ .../compare/virt-install-kvm-centos7.xml | 2 ++ .../compare/virt-install-kvm-f14-url.xml | 2 ++ .../compare/virt-install-kvm-rhel6.xml | 2 ++ .../compare/virt-install-kvm-rhel7.xml | 2 ++ .../compare/virt-install-kvm-session-defaults.xml | 2 ++ .../compare/virt-install-kvm-win2k3-cdrom.xml | 2 ++ .../compare/virt-install-location-iso.xml | 2 ++ .../compare/virt-install-location-nfs.xml | 2 ++ .../compare/virt-install-many-devices.xml | 1 + .../compare/virt-install-panic-default.xml | 1 + .../compare/virt-install-panic-isa-iobase.xml | 1 + .../compare/virt-install-panic-isa.xml | 1 + .../compare/virt-install-q35-defaults.xml | 2 ++ .../compare/virt-install-qemu-32-on-64.xml | 1 + .../compare/virt-install-qemu-plain.xml | 1 + .../compare/virt-install-singleton-config-1.xml | 1 + .../compare/virt-install-solaris10-defaults.xml | 1 + .../cli-test-xml/compare/virt-install-spice-gl.xml | 1 + .../compare/virt-install-win7-uefi.xml | 2 ++ tests/clitest.py | 42 ++++++++++++---------- .../ovf2libvirt_ovf_directory.libvirt | 1 + .../libvirt_output/ovf2libvirt_test1.libvirt | 1 + .../ovf2libvirt_test1.libvirt.disk_qcow2 | 1 + .../libvirt_output/ovf2libvirt_test2.libvirt | 1 + .../libvirt_output/ovf2libvirt_test_gzip.libvirt | 1 + .../ovf2libvirt_test_gzip.libvirt.disk_raw | 1 + .../vmx2libvirt_test-nodisks.libvirt | 1 + .../vmx2libvirt_test-vmx-zip.libvirt | 1 + .../libvirt_output/vmx2libvirt_test1.libvirt | 1 + .../vmx2libvirt_test1.libvirt.disk_raw | 1 + .../libvirt_output/vmx2libvirt_vmx-dir.libvirt | 1 + tests/virtconvtest.py | 4 +++ tests/xmlparse-xml/change-guest-out.xml | 1 + tests/xmlparse.py | 4 ++- virtinst/cli.py | 1 + virtinst/connection.py | 12 ++++++- virtinst/domainfeatures.py | 2 ++ virtinst/guest.py | 5 +++ virtinst/support.py | 2 ++ 53 files changed, 152 insertions(+), 21 deletions(-) create mode 100644 tests/cli-test-xml/compare/virt-install-features-vmcoreinfo.xml -- 2.16.1.73.g5832b7e9f2 _______________________________________________ virt-tools-list mailing list virt-tools-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/virt-tools-list