At 2017-10-02 17:58:58, "Pavel Hrdina" <phrdina@xxxxxxxxxx> wrote: >On Wed, Sep 20, 2017 at 04:06:49PM +0800, Chen Hanxiao wrote: >> From: Chen Hanxiao <chenhanxiao@xxxxxxxxx> >> >> # Define the change > >This change will fix the E125 warning but it could be extended to fix >the E128 warning as well. Otherwise these lines would be modified twice >in order to fix both warnings. What I would suggest is to create a >patch series, that fixes all of E126, E127, E128, E125, E129, E122 in >that order. These warnings are slightly related. > Sorry for the late reply. As [1], this patch fix 4 E128 but introduce a new one. We had too many E128 warnings : < When I had time, I'll create a series with the order as your suggestion. With Cole's ACK, I'll push this patch later. Regards, - Chen [1]: diff of pylint output w/o this fix: --- 2.log 2017-10-21 14:26:02.368745056 +0800 +++ 1.log 2017-10-21 14:22:41.000000000 +0800 @@ -1,4 +1,4 @@ -old +new setup.py:165: [E128] continuation line under-indented for visual indent setup.py:266: [E128] continuation line under-indented for visual indent virt-install:379: [E128] continuation line under-indented for visual indent @@ -281,8 +281,6 @@ virtinst/osdict.py:378: [E128] continuation line under-indented for visual indent virtinst/osdict.py:560: [E128] continuation line under-indented for visual indent virtinst/storage.py:74: [E128] continuation line under-indented for visual indent -virtinst/storage.py:378: [E128] continuation line under-indented for visual indent -virtinst/storage.py:379: [E128] continuation line under-indented for visual indent virtinst/storage.py:411: [E128] continuation line under-indented for visual indent virtinst/storage.py:455: [E128] continuation line under-indented for visual indent virtinst/storage.py:631: [E128] continuation line under-indented for visual indent @@ -556,6 +554,7 @@ virtManager/details.py:904: [E128] continuation line under-indented for visual indent virtManager/details.py:987: [E128] continuation line under-indented for visual indent virtManager/details.py:989: [E128] continuation line under-indented for visual indent +virtManager/details.py:1135: [E128] continuation line under-indented for visual indent virtManager/details.py:1824: [E128] continuation line under-indented for visual indent virtManager/details.py:1986: [E128] continuation line under-indented for visual indent virtManager/details.py:1987: [E128] continuation line under-indented for visual indent @@ -801,9 +800,7 @@ virtManager/viewers.py:576: [E128] continuation line under-indented for visual indent virtManager/viewers.py:621: [E128] continuation line under-indented for visual indent virtManager/viewers.py:624: [E128] continuation line under-indented for visual indent -virtManager/viewers.py:628: [E128] continuation line under-indented for visual indent virtManager/viewers.py:637: [E128] continuation line under-indented for visual indent -virtManager/viewers.py:643: [E128] continuation line under-indented for visual indent virtManager/viewers.py:694: [E128] continuation line under-indented for visual indent virtManager/viewers.py:700: [E128] continuation line under-indented for visual indent virtManager/viewers.py:717: [E128] continuation line under-indented for visual indent _______________________________________________ virt-tools-list mailing list virt-tools-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/virt-tools-list
