Re: [virt-manager PATCH] network: Set bridge name to None instead of blank

[Cole Robinson <crobinso@xxxxxxxxxx>]

On 10/19/2017 04:56 AM, Lin Ma wrote:
> Trigger libvirt error if user leaves 'net-bridge-name' GtkEntry
> blank when specifying shared device name.
> 
> Signed-off-by: Lin Ma <lma@xxxxxxxx>
> ---
>  virtManager/netlist.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/virtManager/netlist.py b/virtManager/netlist.py
> index 772e988..4f1e991 100644
> --- a/virtManager/netlist.py
> +++ b/virtManager/netlist.py
> @@ -314,7 +314,7 @@ class vmmNetworkList(vmmGObjectUI):
>  
>          if net_check_bridge and bridge_entry:
>              net_type = virtinst.VirtualNetworkInterface.TYPE_BRIDGE
> -            net_src = bridge_entry.get_text()
> +            net_src = bridge_entry.get_text() or None
>  
>          mode = None
>          if self.widget("net-source-mode").is_visible():
> 

ACK and pushed

Thanks,
Cole

_______________________________________________
virt-tools-list mailing list
virt-tools-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/virt-tools-list