On 09/08/2017 04:32 AM, Pavel Hrdina wrote: > If initialization of new object fails we put it into blacklist and > newer parse it again until virt-manager is restarted. This helps to > reduce number of failures if some object fails initialization every > time. > > However, there are some cases where we put object into blacklist > incorrectly. One of the cases is while creating new storage pool. > If the storage pool requires to be build before started but user > doesn't check to build it as well the start of the new storage pool > fails. The issue is that at first we define that object which triggers > a lifecycle event for storage pool and queues new poll operation over > storage pools. Before the poll operation starts the starting of the > storage pools fails and we undefine that storage pool before it is > initialized. The initialization fails and the storage pool is never > managed from that point. > > This patch modifies the blacklist to allow 3 failures before we give up > on a specific object and if the object is initialized without error > we remove it from blacklist completely. > > Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1446486 > Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1093394 > > Signed-off-by: Pavel Hrdina <phrdina@xxxxxxxxxx> ACK Thanks, Cole _______________________________________________ virt-tools-list mailing list virt-tools-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/virt-tools-list
