Apart from the patches there is one more improvement that could by done. For --panic default we could generate an empty XML element <panic/> which is accepted by libvirt and libvirt fills in the default values. However, I was not able to achieve that because for some reason the xmlbuilder ignored the empty element. Pavel Hrdina (5): virtinst: remove address configuration from panic device virtManager: remove panic iobase from GUI devicepanic: use model instead of address.type devicepanic: don't set default iobase devicepanic: add all models supported by libvirt man/virt-install.pod | 2 +- .../compare/virt-install-many-devices.xml | 2 +- .../compare/virt-install-panic-default.xml | 33 +++++++++++++ .../compare/virt-install-panic-isa-iobase.xml | 35 ++++++++++++++ .../compare/virt-install-panic-isa.xml | 33 +++++++++++++ .../compare/virt-install-panic-pseries-default.xml | 18 ++++++++ .../compare/virt-install-panic-s390x-default.xml | 20 ++++++++ .../compare/virt-install-singleton-config-1.xml | 4 +- .../compare/virt-install-singleton-config-2.xml | 4 +- tests/clitest.py | 16 +++++++ ui/addhardware.ui | 33 ++----------- ui/details.ui | 32 ++----------- virtManager/addhardware.py | 31 +++++-------- virtManager/details.py | 16 +------ virtinst/cli.py | 24 +++++++--- virtinst/devicepanic.py | 54 ++++++++++++++++++---- virtinst/guest.py | 7 +++ 17 files changed, 249 insertions(+), 115 deletions(-) create mode 100644 tests/cli-test-xml/compare/virt-install-panic-default.xml create mode 100644 tests/cli-test-xml/compare/virt-install-panic-isa-iobase.xml create mode 100644 tests/cli-test-xml/compare/virt-install-panic-isa.xml create mode 100644 tests/cli-test-xml/compare/virt-install-panic-pseries-default.xml create mode 100644 tests/cli-test-xml/compare/virt-install-panic-s390x-default.xml -- 2.13.5 _______________________________________________ virt-tools-list mailing list virt-tools-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/virt-tools-list
