At 2017-08-07 05:35:48, "Cole Robinson" <crobinso@xxxxxxxxxx> wrote: >On 08/05/2017 03:01 AM, Chen Hanxiao wrote: >> From: Chen Hanxiao <chenhanxiao@xxxxxxxxx> >> >> Fix all E203 whitespace before ':' >> >> Signed-off-by: Chen Hanxiao <chenhanxiao@xxxxxxxxx> > >This one is also already ignored in tests/pycodestyle.cfg, is it giving you >warnings? > >That said this is one that I'm fine with keeping as long as we can preserve >horizontal alignment in a few places, which you've kept. But I'm curious as to >how you hit these issues. What version of pycodestyle do you have installed? > >- Cole > >$ pycodestyle --version >2.0.0 I'll push [2/2] later. # pycodestyle --version 2.0.0 # python setup.py pylint running pylint running pycodestyle setup.py:73:5: E301 expected 1 blank line, found 0 setup.py:143:25: E129 visually indented line with same indent as next logical line setup.py:175:5: E303 too many blank lines (2) setup.py:214:5: E303 too many blank lines (2) setup.py:294:5: E301 expected 1 blank line, found 0 setup.py:347:5: E303 too many blank lines (2) setup.py:482:1: E303 too many blank lines (3) ..... hundreds of lines. Looks the ignore config not actting as we wished on my Fedora24. Regards, - Chen _______________________________________________ virt-tools-list mailing list virt-tools-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/virt-tools-list
