Re: [virt-bootstrap] [PATCH v5 04/11] DockerSource: Show correct err msg on skopeo fail

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 2017-07-24 at 09:14 +0100, Radostin Stoyanov wrote:
> The first argument of CalledProcessError() must be the returncode not
> the command.
> ---
>  src/virtBootstrap/sources.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/virtBootstrap/sources.py b/src/virtBootstrap/sources.py
> index 898993d..c44b2ed 100644
> --- a/src/virtBootstrap/sources.py
> +++ b/src/virtBootstrap/sources.py
> @@ -264,7 +264,7 @@ class DockerSource(object):
>          # Without `make_async`, `fd.read` in `read_async` blocks.
>          utils.make_async(proc.stdout)
>          if not self.parse_output(proc):
> -            raise CalledProcessError(cmd, proc.stderr.read())
> +            raise CalledProcessError(proc.returncode, ' '.join(cmd))
>  
>      def validate_image_layers(self):
>          """

ACK

--
Cedric

_______________________________________________
virt-tools-list mailing list
virt-tools-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/virt-tools-list




[Index of Archives]     [Linux Virtualization]     [KVM Development]     [CentOS Virtualization]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite Forum]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]     [Video 4 Linux]

  Powered by Linux