On Mon, May 15, 2017 at 01:36:43PM +0100, Darren Kenny wrote:
> Hi,
>
> I have a patch to add support for Logical Domains (LDoms)
> virtualization on SPARC chipsets running Oracle Linux for SPARC.
>
> At the moment Oracle Linux for SPARC is the only variant that
> support LDoms, but it is hoped will change in the future.
>
> The virt-what tool seems to be a very useful way to identify the
> running virtualization technology, and for anyone that requires it,
> we would like to be able to also identify most of the various LDoms
> domain types that can be done in a script.
>
> Attached is the patch that provides this support, outputting one or
> more of the strings:
>
> ldoms
> ldoms-control
> ldoms-root
> ldoms-io
>
> I would like to get this applied upstream to the virt-what sources
> if that is at all possible.
Hi, sorry I forgot about this until you reminded me just now.
Could you first rebase the patch on top of current git master.
Then I have some comments below ...
> diff -u virt-what-1.15/virt-what.in virt-what-1.15-ldoms/virt-what.in
> --- virt-what-1.15/virt-what.in 2015-03-27 20:39:40.000000000 +0000
> +++ virt-what-1.15-ldoms/virt-what.in 2017-05-08 11:30:36.223265250 +0100
> @@ -291,3 +291,22 @@
> if [ -f "${root}/.dockerinit" ]; then
> echo docker
> fi
> +
> +#Check for LDoms
Add a space after the # character.
It would be nice to have a test case too, although that's a bit more
work. It'll ensure that it doesn't regress for any reason in future
since it's unlikely I would ever have a Sparc machine to test this on
for real ...
Rich.
--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-builder quickly builds VMs from scratch
http://libguestfs.org/virt-builder.1.html
_______________________________________________
virt-tools-list mailing list
virt-tools-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/virt-tools-list
