Hi, On Thu, Jun 08, 2017 at 06:51:01PM -0300, Eduardo Lima (Etrunko) wrote: > On 08/06/17 18:41, Victor Toso wrote: > > Hi, > > > > I would try to short a little bit the shortlog although is very clear. > > > > Maybe from > > "remote-viewer: Show authentication dialog again if in kiosk mode and > > connecting to ovirt" > > > > to > > > > "remote-viewer: Show auth dialog on kiosk mode if connecting to ovirt" > > > > Up to you if you want to change it. > > I would like to keep "again" word, but I could indeed actually use > "auth" instead of "authentication". > > > > > On Thu, Jun 08, 2017 at 06:30:19PM -0300, Eduardo Lima (Etrunko) wrote: > >> Similar to previous commits, but the case for connecting directly to > >> ovirt:// URIs was not dealt with. > > > > I would reference the last two hashes just to be easy to cherry-pick if > > necessary, from commit log ;) ~ Up to you too. > > > > They are: > > > > fb14a8b300ed8 > > 6480e52f62bc7 > > > > Actually this one is similar to > 5d9e6d2338cbb680fe761b86e6ca433b1234e6e0, those two are about not > showing error message if the authentication dialog is canceled. aha! Thanks for double checking :) > > > > >> Related: https://bugzilla.redhat.com/show_bug.cgi?id=1446161 > > > > Better to change it to: > > Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1459808 > > > > Oh, I only noticed the new bug now. > > >> > >> Signed-off-by: Eduardo Lima (Etrunko) <etrunko@xxxxxxxxxx> > > Acked-by: Victor Toso <victortoso@xxxxxxxxxx> > > Thanks, pushed as 0cd836dd1788bb935440699ba3c3da7f4dc06396. Cheers, > > >> --- > >> v3: *Really* fix loop conditional. > >> --- > >> src/remote-viewer.c | 14 ++++++++++---- > >> 1 file changed, 10 insertions(+), 4 deletions(-) > >> > >> diff --git a/src/remote-viewer.c b/src/remote-viewer.c > >> index 2db76bc..4850d7e 100644 > >> --- a/src/remote-viewer.c > >> +++ b/src/remote-viewer.c > >> @@ -738,19 +738,25 @@ authenticate_cb(RestProxy *proxy, G_GNUC_UNUSED RestProxyAuth *auth, > >> gchar *password = NULL; > >> VirtViewerWindow *window; > >> gboolean success = FALSE; > >> + gboolean kiosk = FALSE; > >> > >> g_object_get(proxy, > >> "username", &username, > >> NULL); > >> > >> + g_object_get(G_OBJECT(user_data), "kiosk", &kiosk, NULL); > >> + > >> if (username == NULL || *username == '\0') > >> username = g_strdup(g_get_user_name()); > >> > >> window = virt_viewer_app_get_main_window(VIRT_VIEWER_APP(user_data)); > >> - success = virt_viewer_auth_collect_credentials(virt_viewer_window_get_window(window), > >> - "oVirt", > >> - NULL, > >> - &username, &password); > >> + do { > >> + success = virt_viewer_auth_collect_credentials(virt_viewer_window_get_window(window), > >> + "oVirt", > >> + NULL, > >> + &username, &password); > >> + } while (kiosk && !success); > >> + > >> if (success) { > >> g_object_set(G_OBJECT(proxy), > >> "username", username, > >> -- > >> 2.9.4 > >> > >> _______________________________________________ > >> virt-tools-list mailing list > >> virt-tools-list@xxxxxxxxxx > >> https://www.redhat.com/mailman/listinfo/virt-tools-list > > > -- > Eduardo de Barros Lima (Etrunko) > Software Engineer - RedHat > etrunko@xxxxxxxxxx
Attachment:
signature.asc
Description: PGP signature
_______________________________________________ virt-tools-list mailing list virt-tools-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/virt-tools-list
