On Sun, May 28, 2017 at 05:55:26PM +0100, Radostin Stoyanov wrote: > Resolve three other deprecations "use-action-appearance", "GtkSeparator" and "GtkHPaned". > > GtkActivatable:use-action-appearance has been deprecated since version 3.10 and should not be used in newly-written code. > https://developer.gnome.org/gtk3/stable/GtkActivatable.html#GtkActivatable--use-action-appearance > > GtkHSeparator has been deprecated, use GtkSeparator instead. > https://developer.gnome.org/gtk3/stable/GtkHSeparator.html > > GtkHPaned has been deprecated, use GtkPaned instead. > https://developer.gnome.org/gtk3/stable/GtkHPaned.html This should be split into 3 separate patches. > --- > INSTALL.md | 2 +- > ui/connect.ui | 2 +- > ui/host.ui | 4 ++-- > ui/migrate.ui | 1 - > 4 files changed, 4 insertions(+), 5 deletions(-) > > diff --git a/INSTALL.md b/INSTALL.md > index a34ca77..399dd11 100644 > --- a/INSTALL.md > +++ b/INSTALL.md > @@ -37,6 +37,6 @@ Minimum version requirements of major components: > - libosinfo >= 0.2.10 > > On Debian or Ubuntu based distributions, you need to install the > -`gobject-introspection` bindings for some depedencies like `libvirt-glib` > +`gobject-introspection` bindings for some dependencies like `libvirt-glib` This change is unrelated to the deprecation changes and should be moved to a separate patch, so you should create 4 different patches in total instead of this one. It may seem pointless, but it's a good practice to split the changes. The subject may give you a hint if you should spit it or not, for example subject "Other deprecations" calls for an attention, you don't know what's happening unless you read the commit body as well. Pavel
Attachment:
signature.asc
Description: Digital signature
_______________________________________________ virt-tools-list mailing list virt-tools-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/virt-tools-list
