On Mon, Apr 24, 2017 at 09:42:43AM +0200, Pavel Grunt wrote:
> Build with libvirt only when libvirt-glib is present
There is already such a check right after the part you modified:
AS_IF([test "x$with_libvirt" != "xno" && test "x$with_libvirt" != "xyes"],
[PKG_CHECK_EXISTS([libvirt >= $LIBVIRT_REQUIRED],
[with_libvirt=yes], [with_libvirt=no])])
AS_IF([test "x$with_libvirt" = "xyes"],
[PKG_CHECK_MODULES(LIBVIRT, [libvirt >= $LIBVIRT_REQUIRED] [libvirt-glib-1.0 >= $LIBVIRT_GLIB_REQUI
[AC_DEFINE([HAVE_LIBVIRT], 1, [Have libvirt?])]
)
AM_CONDITIONAL([HAVE_LIBVIRT], [test "x$with_libvirt" = "xyes"])
The check you modified is when we autodetect libvirt presence rather than
having an explicit --with[out]-libvirt.
In such a situation, we expect libvirt support to be silently enabled/disabled
depending on what is installed. This fails when libvirt is detected, but
libvirt-glib is missing/too old. In this situation, without your change,
configure would error out when we expect it to just disable libvirt support.
Your patch should fix this case, and disable libvirt support in this situation.
If my understanding is correct,
Acked-by: Christophe Fergeau <cfergeau@xxxxxxxxxx>
with a more detailed commit log.
Christophe
> ---
> configure.ac | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/configure.ac b/configure.ac
> index d5eb258..0081375 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -118,7 +118,7 @@ AC_ARG_WITH([libvirt],
> AS_HELP_STRING([--without-libvirt], [Ignore presence of libvirt and disable it]))
>
> AS_IF([test "x$with_libvirt" != "xno" && test "x$with_libvirt" != "xyes"],
> - [PKG_CHECK_EXISTS([libvirt >= $LIBVIRT_REQUIRED],
> + [PKG_CHECK_EXISTS([libvirt >= $LIBVIRT_REQUIRED libvirt-glib-1.0 >= $LIBVIRT_GLIB_REQUIRED],
> [with_libvirt=yes], [with_libvirt=no])])
>
> AS_IF([test "x$with_libvirt" = "xyes"],
> --
> 2.12.2
>
> _______________________________________________
> virt-tools-list mailing list
> virt-tools-list@xxxxxxxxxx
> https://www.redhat.com/mailman/listinfo/virt-tools-list
Attachment:
signature.asc
Description: PGP signature
_______________________________________________ virt-tools-list mailing list virt-tools-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/virt-tools-list
