Re: [virt-manager PATCH] nodedev: remove useless exception instance

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




At 2017-03-30 22:12:34, "Cole Robinson" <crobinso@xxxxxxxxxx> wrote:
>On 03/30/2017 06:20 AM, Chen Hanxiao wrote:
>> From: Chen Hanxiao <chenhanxiao@xxxxxxxxx>
>> 
>> Commit f341352cdadeadedab1579d1759ed1387aa28c75
>> removed redundant error string,
>> so the instance 'e' in exception is useless.
>> Just delete it.
>> 
>> Signed-off-by: Chen Hanxiao <chenhanxiao@xxxxxxxxx>
>> ---
>>  virtinst/nodedev.py | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>> 
>> diff --git a/virtinst/nodedev.py b/virtinst/nodedev.py
>> index f82ba35..c8f5adc 100644
>> --- a/virtinst/nodedev.py
>> +++ b/virtinst/nodedev.py
>> @@ -84,7 +84,7 @@ class NodeDevice(XMLBuilder):
>>  
>>          try:
>>              return _AddressStringToNodedev(conn, idstring)
>> -        except Exception, e:
>> +        except Exception:
>>              logging.debug("Error looking up nodedev from idstring=%s",
>>                  idstring, exc_info=True)
>>              raise
>> 
>
>ACK
>

Pushed.

Regards,
- Chen

_______________________________________________
virt-tools-list mailing list
virt-tools-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/virt-tools-list



[Index of Archives]     [Linux Virtualization]     [KVM Development]     [CentOS Virtualization]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite Forum]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]     [Video 4 Linux]

  Powered by Linux