Hi, On Thu, 2017-02-09 at 17:22 -0200, Eduardo Lima (Etrunko) wrote: > This whole series is the result of the initial idea of having the > new > iso-dialog to use this widget. Having it done only for the iso- > dialog > would not make much sense, so I went on and ported all other > dialogs. > The widget requires Gtk version 3.12, which should not be a problem > for > any recent distro. > > Using GtkHeaderBar makes dialogs look cleaner and more 'modern', > also > follow the style used by GNOME applications. In the near future, > virt-viewer main window could also make use of it, as we recently > saw in > a series sent to this mailing list. so are we going for the GNOME style for all desktop envs ? In my opinion it does not look nice in Windows and Xfce - simply does not fit it in. iirc it was mentioned that there is a way to have both the classic and the GNOME look in the discussion about Sagar's patches few weeks ago.. Pavel > > Eduardo Lima (Etrunko) (10): > Update Gtk+ requirements to 3.12 > iso-dialog: Use GtkHeaderBar > guest-details-dialog: Use GtkHeaderBar > virt-viewer-vm-connection: Use GtkHeaderBar > remote-viewer-connect: Use GtkHeaderBar > virt-viewer-preferences: Use GtkHeaderBar > about-dialog: Use GtkHeaderBar > virt-viewer-auth: Use GtkHeaderBar > file-transfer-dialog: Use GtkHeaderBar > usb_device_selection: Use GtkHeaderBar > > configure.ac | 4 +- > src/remote-viewer-connect.c | 20 +-- > src/remote-viewer-iso-list-dialog.c | 32 +++- > src/resources/ui/remote-viewer-connect.ui | 173 ++++++-- > ------------- > src/resources/ui/remote-viewer-iso-list.ui | 87 ++++---- > --- > src/resources/ui/virt-viewer-about.ui | 20 ++- > src/resources/ui/virt-viewer-auth.ui | 148 ++++++++ > ---------- > .../ui/virt-viewer-file-transfer-dialog.ui | 72 +++------ > src/resources/ui/virt-viewer-guest-details.ui | 64 ++++---- > src/resources/ui/virt-viewer-preferences.ui | 103 ++++++-- > ---- > src/resources/ui/virt-viewer-vm-connection.ui | 83 ++++------ > src/virt-viewer-app.c | 38 +++-- > src/virt-viewer-auth.c | 35 +++-- > src/virt-viewer-file-transfer-dialog.c | 59 +++---- > src/virt-viewer-session-spice.c | 20 ++- > src/virt-viewer-vm-connection.c | 15 +- > src/virt-viewer-window.c | 21 ++- > 17 files changed, 437 insertions(+), 557 deletions(-) > _______________________________________________ virt-tools-list mailing list virt-tools-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/virt-tools-list
