On 09/02/17 10:00, Christophe de Dinechin wrote:
> When running 'remote-viewer' without arguments,
> and selecting a non-supported protocol, e.g. ssh://foo,
> the generated error was silently swallowed by the retry loop.
> This was introduced in 06b2c382468876a19600374bd59475e66d488af8.
> ---
> src/remote-viewer.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/src/remote-viewer.c b/src/remote-viewer.c
> index 13c6e7c..e4b0909 100644
> --- a/src/remote-viewer.c
> +++ b/src/remote-viewer.c
> @@ -1196,6 +1196,9 @@ cleanup:
> type = NULL;
>
> if (!ret && priv->open_recent_dialog) {
> + if (error != NULL) {
> + virt_viewer_app_simple_message_dialog(app, _("Unable to connect: %s"), error->message);
> + }
> g_clear_error(&error);
> goto retry_dialog;
> }
>
Sorry for starting this endless discussion about checking for
error->message, it has been shown that it is not necessary (TIL). As
this version addresses the comments of explicit checking, from Pavel,
it's an Ack.
Acked-by: Eduardo Lima (Etrunko) <etrunko@xxxxxxxxxx>
--
Eduardo de Barros Lima (Etrunko)
Software Engineer - RedHat
etrunko@xxxxxxxxxx
_______________________________________________
virt-tools-list mailing list
virt-tools-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/virt-tools-list
