On Mon, 2017-02-06 at 18:04 +0100, Christophe Fergeau wrote: > On Mon, Feb 06, 2017 at 05:55:58PM +0100, Pavel Grunt wrote: > > On Fri, 2017-02-03 at 14:42 -0200, Eduardo Lima (Etrunko) wrote: > > > On 03/02/17 14:34, Christophe Fergeau wrote: > > > > Hey, > > > > > > > > On Thu, Jan 26, 2017 at 06:01:23PM -0200, Eduardo Lima > > > > (Etrunko) > > > > wrote: > > > > > We must take into account that users can close the dialog at > > > > > anytime, > > > > > even during an operation of fetch or set ISO has not been > > > > > finished. This > > > > > will cause the callbacks for those operations to be invoked > > > > > with > > > > > an > > > > > invalid object, crashing the application. > > > > > > > > > > To fix this issue we need to pass a GCancellable to the > > > > > asynchronous > > > > > operations, so they can be cancelled if the dialog happens > > > > > to > > > > > get closed > > > > > before they complete. > > > > > > > > > > > > > This is going to depend on libgovirt bug > > > > https://bugzilla.gnome.org/show_bug.cgi?id=777808 being fixed, > > > > otherwise > > > > we'd be getting a deadlock, is that correct? > > > > > > > > > > Yes, this patch depends on the fix in libgovirt. > > > > so there has to be a version check (or a bump of requirements). > > I've been wondering about that, but I think the consequence of that > bug is a > deadlock in a corner case (closing the dialog while it's still > loading ISOs), so I would say that we can live the dependency on > libgovir as it currently is (otherwise we're going to depend on an > unreleased version of libgovirt). ok, but a comment (TODO: bump libgovirt version to ... to avoid the deadlock) would be nice Pavel > > Christophe _______________________________________________ virt-tools-list mailing list virt-tools-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/virt-tools-list
