[virt-manager PATCH 1/2] interface: Return mac address correctly for bridge devices

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Because a bridge xml doesn't include its own mac item, what it contains
are the slave devices's mac, It causes the get_xmlobj().macaddr can't
return the mac address of bridge.

So while showing host details, The bridge's mac address is displayed as
'Unknown' in tab 'Network Interfaces'. Say virbr0, We known a dummp tap
was already connected to it to maintain a fixed mac address for virbr0,
But its mac is displayed as 'Unknown' in tab 'Network Interfaces'.

The patch fixed the issue by returning mac from backend instead of xml.

Signed-off-by: Lin Ma <lma@xxxxxxxx>
---
 virtManager/interface.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/virtManager/interface.py b/virtManager/interface.py
index 3af5974..626465e 100644
--- a/virtManager/interface.py
+++ b/virtManager/interface.py
@@ -81,7 +81,7 @@ class vmmInterface(vmmLibvirtObject):
     ################
 
     def get_mac(self):
-        return self.get_xmlobj().macaddr
+        return self._backend.MACString()
 
     def is_bridge(self):
         typ = self.get_type()
-- 
2.9.2

_______________________________________________
virt-tools-list mailing list
virt-tools-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/virt-tools-list



[Index of Archives]     [Linux Virtualization]     [KVM Development]     [CentOS Virtualization]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite Forum]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]     [Video 4 Linux]

  Powered by Linux