Re: [PATCH virt-viewer] Do not print credentials in the debug log

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hey,

On Wed, Jan 04, 2017 at 10:44:22AM +0100, Pavel Grunt wrote:
> Resolves: rhbz#1410030
> ---
>  src/virt-viewer.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/src/virt-viewer.c b/src/virt-viewer.c
> index 1121146..4da5cd5 100644
> --- a/src/virt-viewer.c
> +++ b/src/virt-viewer.c
> @@ -936,7 +936,6 @@ virt_viewer_auth_libvirt_credentials(virConnectCredentialPtr cred,
>                  cred[i].resultlen = strlen(cred[i].result);
>              else
>                  cred[i].resultlen = 0;
> -            g_debug("Got '%s' %d %d", cred[i].result, cred[i].resultlen, cred[i].type);

I'd keep the g_debug for AUTHNAME/USERNAME, and have some placeholder for
PASSPHRASE ("Got passphrase XXX %d", cred[i].type))

Christophe

Attachment: signature.asc
Description: PGP signature

_______________________________________________
virt-tools-list mailing list
virt-tools-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/virt-tools-list

[Index of Archives]     [Linux Virtualization]     [KVM Development]     [CentOS Virtualization]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite Forum]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]     [Video 4 Linux]

  Powered by Linux