Snir,
The code itself is okay, but I have some suggestions for the commit message.
Although the commit messages here are not exactly following a style,
something like "component: and here the commig log" is desirable.
So, what about ... "spice: Fix display id in the warning log" ?
On Tue, Dec 27, 2016 at 10:55 AM, Snir Sheriber <ssheribe@xxxxxxxxxx> wrote:
> The display id in the warning message is now consistent with display id
> in the "view->displays->display x" menu item
>
> rhbz#1368390
Here, it makes the downstream maintainer's life easier if you add:
Resolves/Related and then the bug reference. Something like:
Resolves: rhbz#1368390
> ---
> src/virt-viewer-session-spice.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/virt-viewer-session-spice.c b/src/virt-viewer-session-spice.c
> index 731f074..c24f94d 100644
> --- a/src/virt-viewer-session-spice.c
> +++ b/src/virt-viewer-session-spice.c
> @@ -915,7 +915,7 @@ virt_viewer_session_spice_display_monitors(SpiceChannel *channel,
> if (!disabled && fullscreen_mode && self->priv->did_auto_conf &&
> !display_is_in_fullscreen_mode(self, VIRT_VIEWER_DISPLAY(display))) {
> g_warning("display %d should not be enabled, disabling",
> - virt_viewer_display_get_nth(VIRT_VIEWER_DISPLAY(display)));
> + virt_viewer_display_get_nth(VIRT_VIEWER_DISPLAY(display)) + 1);
> spice_main_set_display_enabled(virt_viewer_session_spice_get_main_channel(self),
> virt_viewer_display_get_nth(VIRT_VIEWER_DISPLAY(display)),
> FALSE);
> --
> 2.9.3
>
> _______________________________________________
> virt-tools-list mailing list
> virt-tools-list@xxxxxxxxxx
> https://www.redhat.com/mailman/listinfo/virt-tools-list
Please, submit a v2 with these changes and thanks for the contribution!
Ah, while on this, the same comments about the commit log and commit
message applies to your other patch.
Best Regards,
--
Fabiano Fidêncio
_______________________________________________
virt-tools-list mailing list
virt-tools-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/virt-tools-list
