Hi ----- Original Message ----- > On 11/28/2016 05:47 AM, marcandre.lureau@xxxxxxxxxx wrote: > > From: Marc-André Lureau <marcandre.lureau@xxxxxxxxx> > > > > Add an OpenGL checkbox to the Spice graphics options (only available if > > SUPPORT_CONN_SPICE_GL). > > > > Sorry for the not reviewing these patches earlier... > > This patch is fine but I'm still on the fence about exposing this in the UI > at > all: > > 1) qemu:///system doesn't work out of the box, which is the common > virt-manager usage true, still waiting on libvirt to allow access to system qemu > 2) the setting isn't really useful in isolation, needs to be combined with > virtio-vga + accel3d setting at least, but the UI doesn't give any help here we could disable the 3d checkbox if virtio isn't the video device? > 3) I fear a trickle of bug reports like 'hey I clicked the GL option but 3D > in > my windows VM still sucks' I am afraid that this will come inevitably :) Even if it worked, I can imagine people will complain that it isn't that much faster, doesn't work with Windows, is buggy with wayland etc.. We have to put pieces together and push people to do the required changes. Otherwise we are stuck, like for the past 6 months, and nobody even bother to test it.. > > I'd rather point people at virt-xml invocations until at least the > qemu:///system issues are straightened out. And after that expose this with > maybe some guest OS awareness, warnings/explaining tooltips, be explicit > about > errors like if a user tries to connect remotely, etc.... But I'm not 100% > sold > either way. Thoughts? Either way works for me. It depends how "finished virt-manager wants to be :) _______________________________________________ virt-tools-list mailing list virt-tools-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/virt-tools-list
