On Wed, 2016-11-02 at 16:23 +0000, Daniel P. Berrange wrote: > On Mon, Oct 24, 2016 at 04:04:21PM -0500, Jonathon Jongsma wrote: > > > > When transferring a large number of files, the file transfer dialog > > was > > unusable because the window size would be larger than the client > > desktop. To solve this, remove the list of individual files (and > > the > > ability to cancel each file transfer independantly) and only > > display > > a single overall progress bar that shows the status of all ongoing > > transfers. > > > > This also allows us to remove the delayed unref of the task since > > we > > don't need to show the task information about each individual > > transfer > > task until the window is closed. Removes TaskFinishedData type. > > > > This patch requires new API from spice-gtk to calculate the overall > > progress: > > spice_file_transfer_task_get_total_bytes() > > spice_file_transfer_task_get_transferred_bytes() > > --- > > configure.ac | 2 +- > > src/Makefile.am | 1 + > > .../ui/virt-viewer-file-transfer-dialog.ui | 87 > > ++++++++++ > > This also breaks the build because you didn't list the newly > translatable > file: > > --- ../po/POTFILES.in > +++ ../po/POTFILES.in > @@ -6,6 +6,7 @@ > src/resources/ui/remote-viewer-connect.ui > src/resources/ui/virt-viewer-about.ui > src/resources/ui/virt-viewer-auth.ui > +src/resources/ui/virt-viewer-file-transfer-dialog.ui > src/resources/ui/virt-viewer-guest-details.ui > src/resources/ui/virt-viewer-preferences.ui > src/resources/ui/virt-viewer-vm-connection.ui > maint.mk: you have changed the set of files with translatable > diagnostics; > apply the above patch > ../maint.mk:1063: recipe for target 'sc_po_check' failed > make: *** [sc_po_check] Error 1 > make: *** Waiting for unfinished jobs.... > Build step 'Execute shell' marked build as failure > > > Please ensure to always runs "make syntax-check" before pushing any > changes. > > Regards, > Daniel Thanks for the reminder. I'll try to be more thorough in the future. _______________________________________________ virt-tools-list mailing list virt-tools-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/virt-tools-list
