On 07/28/2016 05:20 AM, Daniel P. Berrange wrote:
> This latest virt-manager failure looks genuine:
>
> On Thu, Jul 28, 2016 at 09:12:18AM +0000, ci@xxxxxxxxxx wrote:
>> --- tests/cli-test-xml/compare/virt-install-kvm-f14-url.xml
>> +++ Generated Output
>> @@ -50,7 +50,7 @@
>> <mac address="00:11:22:33:44:55"/>
>> <model type="virtio"/>
>> </interface>
>> - <input type="tablet" bus="usb"/>
>> + <input type="virtio1.0-input"/>
>> <graphics type="spice" port="-1" tlsPort="-1" autoport="yes">
>> <image compression="off"/>
>> </graphics>
>> @@ -109,7 +109,7 @@
>> <mac address="00:11:22:33:44:55"/>
>> <model type="virtio"/>
>> </interface>
>> - <input type="tablet" bus="usb"/>
>> + <input type="virtio1.0-input"/>
>> <graphics type="spice" port="-1" tlsPort="-1" autoport="yes">
>> <image compression="off"/>
>> </graphics>
>
> Looks like there's two separate issues here
>
> - The test case is assuming usb tablet, but in fact pulling data
> from libosinfo. Fedora 23 records support for virtio1.0-input
> devices, so this seems to have tripped up the test assumptions
>
> - It looks like the code is just blindly copying the device
> name from libosinfo, into the guest XML, but this is not valid
> since there's not a 1-1 match between dev names in libosinfo
> and device model names in libvirt.
>
> eg, a name virtio1.0-input in libosinfo maps to <input type="virtio">
> in libvirt.
Fixed upstream now:
commit 1d2cd306773064258f5d02c980b09a683ae77798
Author: Cole Robinson <crobinso@xxxxxxxxxx>
Date: Fri Jul 29 13:17:36 2016 -0400
osdict: Fix incorrect usage of virtio input
Regression reported with latest libosinfo, when the OS reports
virtio-input support:
http://www.redhat.com/archives/virt-tools-list/2016-July/msg00109.html
Really our code presently only cares about the USB tablet, so adjust
our libosinfo lookup to explicitly check for it
- Cole
_______________________________________________
virt-tools-list mailing list
virt-tools-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/virt-tools-list
