New version of the ISO list dialog, with changes suggested in first round of reviews and lots of bug fixes. Before sending v1 I had refactored a few bits and it introduced some serious crashes. On the UI side, we now use GtkStack instead of GtkNotebook and the last commit of the series also makes use of more modern looking GtkHeaderBar. It has been kept as a separate commit because it requires newer version of Gtk+ than the one which is currently required. In progress: - Use GtkListBox instead of GtkTreeView. - Rework OvirtForeignMenu/ISOListDialog so that the async API is exposed, making it more robust in case of errors. Eduardo Lima (Etrunko) (12): ovirt-foreign-menu: Rework states logic ovirt-foreign-menu: Use g_clear_pointer/g_clear_object ovirt-foreign-menu: Remove timer used to refresh iso list ovirt-foreign-menu: Add accessors for current iso and iso list ovirt-foreign-menu: Remove GtkMenu related functions ovirt-foreign-menu: Notify of new files even if nothing changed UI: Make 'Change CD' menu item a submenu under 'File' toplevel menu Introduce ISO List dialog Run iso-dialog when 'Change CD' menu is activated remote-viewer: Make ovirt-foreign-menu a property iso-dialog: Implement functionality provided by oVirt foreign menu iso-dialog: Use header bar for buttons configure.ac | 4 +- po/POTFILES.in | 2 + src/Makefile.am | 3 + src/ovirt-foreign-menu.c | 292 ++++++++-------------------- src/ovirt-foreign-menu.h | 5 +- src/remote-viewer-iso-list-dialog.c | 301 +++++++++++++++++++++++++++++ src/remote-viewer-iso-list-dialog.h | 58 ++++++ src/remote-viewer.c | 89 ++++----- src/resources/ui/remote-viewer-iso-list.ui | 158 +++++++++++++++ src/resources/ui/virt-viewer.ui | 19 +- src/resources/virt-viewer.gresource.xml | 1 + src/virt-viewer-window.c | 37 ++++ 12 files changed, 702 insertions(+), 267 deletions(-) create mode 100644 src/remote-viewer-iso-list-dialog.c create mode 100644 src/remote-viewer-iso-list-dialog.h create mode 100644 src/resources/ui/remote-viewer-iso-list.ui -- 2.7.4 _______________________________________________ virt-tools-list mailing list virt-tools-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/virt-tools-list
