On 07/12/2016 03:28 PM, Charles Arnold wrote: > This patchset introduces a command line option to pass smbios information to > the guest. It adds an smbios mode sub-element to the guest's os element. The > mode attribute must be specified and is either "emulate" (let the hypervisor > generate all values), "host" (copy all of Block 0 and Block 1, except for the > UUID, from the host's SMBIOS values), or "sysinfo" (use the values in the > sysinfo element). If not specified, the hypervisor default is used. > > If sysinfo is specified in the smbios mode field then an additional sysinfo > element is added to the guest defining the SMBios information. The sysinfo > element has a mandatory attribute type of "smbios". The smbios information > comes as three sub-types, "bios", "system", and "baseBoard" where each of > these types contains sub-elements . > > Incorrectly supplied entries for the bios, system or baseBoard blocks will be > ignored without error. Other than uuid validation and date format checking, all > values are passed as strings to the hypervisor driver. > > Examples: > --smbios emulate > --smbios host > --smbios type=0,vendor=Vendor_Inc.,version=1.2.3-abc,... > --smbios type=1,manufacturer=System_Corp.,product=codename,... > --smbios type=2,manufacturer=Baseboard_Corp.,product=codename,... > > > .../compare/virt-install-singleton-config-2.xml | 50 +++++++ > tests/clitest.py | 3 + > virtinst/cli.py | 69 +++++++++ > virtinst/guest.py | 4 +- > virtinst/osxml.py | 3 +- > virtinst/sysinfo.py | 158 +++++++++++++++++++++ > 6 files changed, 285 insertions(+), 2 deletions(-) Thanks for the patches! I didn't look super closely yet since I see some problems off the bat. Please use git send-email, so the patch series is properly threaded, and the mail subjects match the commit titles. For example see some of the series that are posted to libvir-list for the expected threading and formatting: http://www.redhat.com/archives/libvir-list/2016-July/thread.html The patches need to be reordered, for example patch #1 uses bits that aren't added until patch #4. I say squash patch 2+3+4 together into the new patch #1, then patch 1+5 is the new patch 2 I prefer to have the command line options mirror the libvirt XML names, so instead call the option --sysinfo. Diverging has gotten us into trouble in the past Thanks, Cole _______________________________________________ virt-tools-list mailing list virt-tools-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/virt-tools-list
