On Tue, Jun 28, 2016 at 5:22 PM, Fabiano Fidêncio <fidencio@xxxxxxxxxx> wrote:
> From: Christophe Fergeau <cfergeau@xxxxxxxxxx>
>
> virt_viewer_timed_revealer_new calls gtk_container_add on the instance
> returned by gtk_revealer_new so VirtViewerTimedRevealer does not own any
> ref on this GtkRevealer instance. Unrefing it in _dispose() is thus wrong.
> ---
> src/virt-viewer-timed-revealer.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/virt-viewer-timed-revealer.c b/src/virt-viewer-timed-revealer.c
> index 9124dad..cad9ede 100644
> --- a/src/virt-viewer-timed-revealer.c
> +++ b/src/virt-viewer-timed-revealer.c
> @@ -126,7 +126,7 @@ virt_viewer_timed_revealer_dispose(GObject *object)
> VirtViewerTimedRevealerPrivate *priv = self->priv;
>
> g_clear_object(&priv->evBox);
> - g_clear_object(&priv->revealer);
> + priv->revealer = NULL;
>
> if (priv->timeout_id) {
> g_source_remove(priv->timeout_id);
> --
> 2.7.4
>
> _______________________________________________
> virt-tools-list mailing list
> virt-tools-list@xxxxxxxxxx
> https://www.redhat.com/mailman/listinfo/virt-tools-list
Acked-by: Fabiano Fidêncio <fidencio@xxxxxxxxxx>
(The backtrace can be added before pushing)
_______________________________________________
virt-tools-list mailing list
virt-tools-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/virt-tools-list
