On Tue, Jun 28, 2016 at 12:08 PM, Pavel Grunt <pgrunt@xxxxxxxxxx> wrote: > Hi Eduardo, > > On Mon, 2016-06-27 at 18:00 -0300, Eduardo Lima (Etrunko) wrote: >> Fixes https://bugs.freedesktop.org/show_bug.cgi?id=94276 >> >> Signed-off-by: Eduardo Lima (Etrunko) <etrunko@xxxxxxxxxx> >> --- >> >> As a result of commit cc455b7f916110d7cfae6b7af753349e070c9494, setting >> custom color for background does not work anymore on my Fedora 23 >> system. The status label still rendered with white color, but with the >> background with default theme color (usually light grey), it has become >> hard to read the text from the label. >> >> I talked to Fabiano who told me that everything was working as expected >> with his recently upgraded Fedora 24 system. While trying to track and >> fix the issue, I noticed that it will only happen if the notebook tabs >> are hidden. If tabs are shown, the background color will be properly >> set. >> >> I tracked down to Gtk+ some changes to GtkNotebook in recently released >> version 3.20, which fixed the rendering of the custom background color, >> with tabs hidden, but those could not be easily backported. Even though >> it is a change of behavior in virt-viewer, I think it is really a minor >> issue, and I decided to not spent too much time on this, so I put a >> check for Gtk+ version to decide whether or not set the custom colors. >> >> Some screenshots to illustrate: >> >> Gtk+ > 3.20: >> http://imgur.com/gpuMukA >> >> Gtk+ < 3.20: >> >> without this patch.: http://imgur.com/RdirSoX >> with this patch....: http://imgur.com/9LJNeNI > > I would make it more simple, stick with the system theme > (ie http://imgur.com/9LJNeNI for all gtk versions) instead of introducing some > css just for 3.20 (is it stable btw ;-) ?). It would simplify the code, imho it > looks better and another gui tool from the family - virt-manager - uses it. > > What do you think ? Hmm. This solution is quite okay for me. If the other people agree, I'd say to proceed with your suggestion then. Best Regards, -- Fabiano Fidêncio _______________________________________________ virt-tools-list mailing list virt-tools-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/virt-tools-list
