On Fri, Jun 24, 2016 at 10:33 AM, Lukas Venhoda <lvenhoda@xxxxxxxxxx> wrote: > Hi > On Thu, Jun 23, 2016 at 6:45 PM, Fabiano Fidêncio <fabiano@xxxxxxxxxxxx> > wrote: >> >> On Thu, Jun 23, 2016 at 4:53 PM, Lukáš Venhoda <lvenhoda@xxxxxxxxxx> >> wrote: >> > Adds metadata to be used with Gnome Software. >> > Includes name, summary, description and three screenshots of >> > remote-viewer. >> > Adds the new file to PO files, and adds instalation of appdata file. >> >> I'd remove this last line from the commit message. >> > > Ok > >> >> > --- >> > data/Makefile.am | 9 +++++++-- >> > data/remote-viewer.appdata.xml.in | 28 ++++++++++++++++++++++++++++ >> > po/POTFILES.in | 1 + >> > virt-viewer.spec.in | 1 + >> > 4 files changed, 37 insertions(+), 2 deletions(-) >> > create mode 100644 data/remote-viewer.appdata.xml.in >> > >> > diff --git a/data/Makefile.am b/data/Makefile.am >> > index 821c171..55718d9 100644 >> > --- a/data/Makefile.am >> > +++ b/data/Makefile.am >> > @@ -76,6 +76,11 @@ mimedir = $(datadir)/mime/packages >> > mime_DATA = virt-viewer-mime.xml >> > @INTLTOOL_XML_RULE@ >> > >> > +appdatadir = $(datadir)/appdata >> > +APPDATAFILES = remote-viewer.appdata.xml.in >> >> I'm thinking whether we should provide a virt-viewer.appdata.xml.in as >> well. >> What do you think, Lukaš? >> > > Well I think there should be only remote-viewer.appdata.xml, because we only > provide only one package. > Yes. the package name is virt-viewer, but with the Provides fix from last > patch this wouldn't be issue. > > If we want to install virt-viewer and remote-viewer from Gnome Software > separatly, then yes it would be better to have both, > but does it make sense to have both if they install the same package? What happens if you try to search for "virt-viewer" in "Software"? Does it return any result? If there's no result returned, we must add a virt-viewer.appdata.xml as well. > >> >> > +appdata_DATA = $(APPDATAFILES:.xml.in=.xml) >> > +@INTLTOOL_XML_RULE@ >> > + >> > install-data-hook: >> > if ENABLE_UPDATE_MIMEDB >> > @if $(AM_V_P); then set -x; else echo " INSTALL >> > update-mime-database"; fi; \ >> > @@ -88,8 +93,8 @@ if ENABLE_UPDATE_MIMEDB >> > $(UPDATE_MIME_DATABASE) "$(DESTDIR)$(datadir)/mime"; >> > endif >> > >> > -CLEANFILES += $(mime_DATA) $(desktop_DATA) >> > -EXTRA_DIST += $(MIMEFILES) $(DESKTOPFILES) >> > +CLEANFILES += $(mime_DATA) $(desktop_DATA) $(appdata_DATA) >> > +EXTRA_DIST += $(MIMEFILES) $(DESKTOPFILES) $(APPDATAFILES) >> > >> > endif >> > >> > diff --git a/data/remote-viewer.appdata.xml.in >> > b/data/remote-viewer.appdata.xml.in >> > new file mode 100644 >> > index 0000000..5aa2ff3 >> > --- /dev/null >> > +++ b/data/remote-viewer.appdata.xml.in >> > @@ -0,0 +1,28 @@ >> > +<?xml version="1.0" encoding="UTF-8"?> >> > +<application> >> > + <id type="desktop">remote-viewer.desktop</id> >> > + <metadata_license>CC0-1.0</metadata_license> >> > + <project_license>GPL-2.0+</project_license> >> > + <_name>Remote Viewer</_name> >> > + <_summary>Remotely access virtual machines</_summary> >> > + <description> >> > + <_p> >> > + Remote Viewer provides a graphical viewer for the guest OS >> > + display. At this time is supports guest OS using the VNC >> >> "(...) At this time it supports (...)" (replace is -> it). >> >> > + or SPICE protocols. Further protocols may be supported in >> > + the future as user demand dictates. The viewer can connect >> > + directly to both local and remotely hosted guest OS, optionally >> > + using SSL/TLS encryption. >> >> Out of curiosity, where this description comes from? >> > > The virt-viewer README. The typo is also there. > Hmm. Nice :-) >> >> > + </_p> >> > + </description> >> > + <screenshots> >> > + <screenshot >> > type="default">http://www.spice-space.org/static/images/remote_viewer_youtube.png</screenshot> >> > + >> > <screenshot>http://www.spice-space.org/static/images/remote_viewer_usbredir.png</screenshot> >> > + >> > <screenshot>http://www.spice-space.org/static/images/remote_viewer_shared_folder.png</screenshot> >> > + </screenshots> >> > + <provides> >> > + <binary>virt-viewer</binary> >> > + </provides> >> > + <url type="homepage">http://www.spice-space.org/</url> >> >> The homepage for virt-viewer is: https://virt-manager.org/ and not >> http://www.spice-space.org >> > > Ok will fix > >> >> > + <updatecontact>virt-tools-list_at_redhat.com</updatecontact> >> > +</application> >> > diff --git a/po/POTFILES.in b/po/POTFILES.in >> > index b25306d..6775f53 100644 >> > --- a/po/POTFILES.in >> > +++ b/po/POTFILES.in >> > @@ -1,3 +1,4 @@ >> > +data/remote-viewer.appdata.xml.in >> > data/remote-viewer.desktop.in >> > data/virt-viewer-mime.xml.in >> > src/remote-viewer-main.c >> > diff --git a/virt-viewer.spec.in b/virt-viewer.spec.in >> > index ed0b14d..4fb649c 100644 >> > --- a/virt-viewer.spec.in >> > +++ b/virt-viewer.spec.in >> > @@ -127,6 +127,7 @@ fi >> > %{_datadir}/icons/hicolor/*/apps/* >> > %{_datadir}/icons/hicolor/*/devices/* >> > %{_datadir}/applications/remote-viewer.desktop >> > +%{_datadir}/appdata/remote-viewer.appdata.xml >> > %{_datadir}/mime/packages/virt-viewer-mime.xml >> > %ghost %{_libexecdir}/spice-xpi-client >> > %{_libexecdir}/spice-xpi-client-remote-viewer >> > -- >> > 2.5.5 >> > >> > _______________________________________________ >> > virt-tools-list mailing list >> > virt-tools-list@xxxxxxxxxx >> > https://www.redhat.com/mailman/listinfo/virt-tools-list >> >> >> Reviewed-by: Fabiano Fidêncio <fidencio@xxxxxxxxxx> >> >> -- >> Fabiano Fidêncio > > > Thanks > -- > Lukas Venhoda > > _______________________________________________ > virt-tools-list mailing list > virt-tools-list@xxxxxxxxxx > https://www.redhat.com/mailman/listinfo/virt-tools-list Best Regards, -- Fabiano Fidêncio _______________________________________________ virt-tools-list mailing list virt-tools-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/virt-tools-list
