Re: [PATCH 2/2] Avoid unecessary debug message if returning NULL

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Jun 23, 2016 at 10:13:25AM -0300, Eduardo Lima (Etrunko) wrote:
> Signed-off-by: Eduardo Lima (Etrunko) <etrunko@xxxxxxxxxx>
> ---
>  src/ovirt-foreign-menu.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/ovirt-foreign-menu.c b/src/ovirt-foreign-menu.c
> index 9b552eb..959804d 100644
> --- a/src/ovirt-foreign-menu.c
> +++ b/src/ovirt-foreign-menu.c
> @@ -465,10 +465,10 @@ GtkWidget *ovirt_foreign_menu_get_gtk_menu(OvirtForeignMenu *foreign_menu)
>      GList *it;
>      char *current_iso;
>  
> -    g_debug("Creating GtkMenu for foreign menu");
>      if (foreign_menu->priv->iso_names == NULL) {
>          return NULL;
>      }
> +    g_debug("Creating GtkMenu for foreign menu");
>      current_iso = ovirt_foreign_menu_get_current_iso_name(foreign_menu);
>      gtk_menu = gtk_menu_new();
>      for (it = foreign_menu->priv->iso_names; it != NULL; it = it->next) {

Fine with me. Actually it might be more useful to have a log when the
Change CD menu does not show up because the iso name list is empty
rather than having a log when something is going to be shown. So maybe
add an additional g_debug() when NULL is returned?

Christophe

> -- 
> 2.5.5
> 
> _______________________________________________
> virt-tools-list mailing list
> virt-tools-list@xxxxxxxxxx
> https://www.redhat.com/mailman/listinfo/virt-tools-list

Attachment: signature.asc
Description: PGP signature

_______________________________________________
virt-tools-list mailing list
virt-tools-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/virt-tools-list

[Index of Archives]     [Linux Virtualization]     [KVM Development]     [CentOS Virtualization]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite Forum]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]     [Video 4 Linux]

  Powered by Linux