On 06/21/2016 05:04 PM, Fabiano Fidêncio wrote:
> Since commit 1f6f1a48 the resource path for icons has been broken.
> The reason is that when moving the .ui files to $(srcdir)/resources/ui,
> the define used for the resources was changed to reflect the new
> directory. However, this change wasn't needed by the icons and ended up
> with virt-viewer not displaying a few icons.
>
> Let's fix the issue by adding a new define for the icon's resource path.
>
> Signed-off-by: Fabiano Fidêncio <fidencio@xxxxxxxxxx>
> ---
> src/virt-viewer-util.h | 1 +
> src/virt-viewer-window.c | 4 ++--
> 2 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/src/virt-viewer-util.h b/src/virt-viewer-util.h
> index 14a477a..7b90052 100644
> --- a/src/virt-viewer-util.h
> +++ b/src/virt-viewer-util.h
> @@ -35,6 +35,7 @@ enum {
>
> #define VIRT_VIEWER_ERROR virt_viewer_error_quark ()
> #define VIRT_VIEWER_RESOURCE_PREFIX "/org/virt-manager/virt-viewer/ui"
> +#define VIRT_VIEWER_RESOURCE_ICONS_PREFIX "/org/virt-manager/virt-viewer"
>
I would prefer if you kept using VIRT_VIEWER_RESOUCE_PREFIX instead of
adding a new define. It could be "/org/virt-manager/virt-viewer" and
then you would adjust other occurrences accordingly (the only one i see
is in virt-viewer-util.c).
--
Eduardo de Barros Lima (Etrunko)
Software Engineer - RedHat
etrunko@xxxxxxxxxx
_______________________________________________
virt-tools-list mailing list
virt-tools-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/virt-tools-list
