Re: [virt-viewer 2/5] remote-viewer: Remove unneeded g_application_hold() call

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 2016-06-14 at 18:59 -0300, Eduardo Lima (Etrunko) wrote:
> On 06/14/2016 06:40 PM, Fabiano Fidêncio wrote:
> > 
> > This call was added as hack during the GApplication's port, as the
> > remote-viewer window was closed as soon as the connection happened.
> > 
> > This behaviour hapened because we didn't chain-up to the parent's
> > window_added() method, which already calls g_application_hold()..
> > 
> > Signed-off-by: Fabiano Fidêncio <fidencio@xxxxxxxxxx>
> > ---
> >  src/virt-viewer-app.c | 2 --
> >  1 file changed, 2 deletions(-)
> > 
> > diff --git a/src/virt-viewer-app.c b/src/virt-viewer-app.c
> > index b99ed32..4c3a373 100644
> > --- a/src/virt-viewer-app.c
> > +++ b/src/virt-viewer-app.c
> > @@ -1825,8 +1825,6 @@ virt_viewer_app_on_application_startup(GApplication
> > *app)
> >          g_application_quit(app);
> >          return;
> >      }
> > -
> > -    g_application_hold(app);
> >  }
> >  
> >  static gboolean
> > 
> Thanks for finding the real problem here. So, this one could be squashed
> with previous one maybe?
> 

Probably not a bad idea.

_______________________________________________
virt-tools-list mailing list
virt-tools-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/virt-tools-list




[Index of Archives]     [Linux Virtualization]     [KVM Development]     [CentOS Virtualization]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite Forum]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]     [Video 4 Linux]

  Powered by Linux