If jsessionid is not set in the .vv file and we try to use anyway the
REST API, an authentication dialog will be shown by remote-viewer, which
is very unwelcome. If we don't have a jsessionid set, we know we won't
be able to silently login to the REST API, so don't try to set a foreign
menu when it's not set.
---
src/ovirt-foreign-menu.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/src/ovirt-foreign-menu.c b/src/ovirt-foreign-menu.c
index 82f0f2a..027cd68 100644
--- a/src/ovirt-foreign-menu.c
+++ b/src/ovirt-foreign-menu.c
@@ -843,8 +843,11 @@ OvirtForeignMenu *ovirt_foreign_menu_new_from_file(VirtViewerFile *file)
ca_str = virt_viewer_file_get_ovirt_ca(file);
admin = virt_viewer_file_get_ovirt_admin(file);
- if ((url == NULL) || (vm_guid == NULL))
+ if ((url == NULL) || (vm_guid == NULL) || (jsessionid == NULL)) {
+ g_debug("ignoring [ovirt] section content as URL, VM GUID or jsessionid"
+ " are missing from the .vv file");
goto end;
+ }
proxy = ovirt_proxy_new(url);
if (proxy == NULL)
--
2.7.4
_______________________________________________
virt-tools-list mailing list
virt-tools-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/virt-tools-list
